Re: [PATCHv2] PCI: fix recursive device locking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Keith Busch wrote:
> From: Keith Busch <kbusch@xxxxxxxxxx>
> 
> If one of the bus' devices has subordinates, the recursive call locks
> itself, so no need to lock the device before the recursion or it will
> surely deadlock.
> 
> Fixes: dbc5b5c0d268f87 ("PCI: Add missing bridge lock to pci_bus_lock()"
> Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
> Signed-off-by: Keith Busch <kbusch@xxxxxxxxxx>
> ---
> Changes from v1:
> 
>  Fixed the same recursive locking for pci_bus_trylock(),
>  pci_slot_lock(), and pci_slot_trylock()

Oh, yes, good find, I should have spotted that earlier.

>  drivers/pci/pci.c | 33 ++++++++++++++++++---------------
>  1 file changed, 18 insertions(+), 15 deletions(-)

Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx>




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux