Re: [PATCH v2] pci: bus: only call of_platform_populate() if CONFIG_OF is enabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2] pci: bus: only call of_platform_populate() if CONFIG_OF is enabled
From: Mario Limonciello <superm1@xxxxxxxxxx>
Date: Mon, 8 Jul 2024 11:01:12 -0500
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>, Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>, Krzysztof Wilczyński <kw@xxxxxxxxx>, Lukas Wunner <lukas@xxxxxxxxx>, Bert Karwatzki <spasswolf@xxxxxx>, caleb.connolly@xxxxxxxxxx, bhelgaas@xxxxxxxxxx, amit.pundir@xxxxxxxxxx, neil.armstrong@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, Praveenkumar Patil <PraveenKumar.Patil@xxxxxxx>
In-reply-to: <CAMRc=MdHSsctXYor2ycWqRJHCUciweRTie_TjW9h0yfN7wZhOA@mail.gmail.com>
References: <20240707183829.41519-1-spasswolf@web.de> <Zoriz1XDMiGX_Gr5@wunner.de> <20240708003730.GA586698@rocinante> <CACMJSevHmnuDk8hpK8W+R7icySmNF8nT1T9+dJDE_KMd4CbGNg@mail.gmail.com> <20240708083317.GA3715331@rocinante> <6e57dbc0-f47a-464e-af6b-abd45c450dc6@kernel.org> <CACMJSetAKtPp_Gua2S7m_+aC-f9HSUyfF1YoHUPdtcibLtQxpA@mail.gmail.com> <20240708154401.GD5745@thinkpad> <664619a9-c80f-4f81-b302-b9c5258b5e0e@kernel.org> <CAMRc=Mf2pE5JVHzcntO5b+5so_=ekuHGzrY=xJpKatURJFpGZA@mail.gmail.com> <8838b5c3-0c51-42f6-9842-186139822be7@kernel.org> <CAMRc=MdHSsctXYor2ycWqRJHCUciweRTie_TjW9h0yfN7wZhOA@mail.gmail.com>
User-agent: Mozilla Thunderbird

On 7/8/2024 10:58, Bartosz Golaszewski wrote:

On Mon, Jul 8, 2024 at 5:53 PM Mario Limonciello <superm1@xxxxxxxxxx> wrote:


On 7/8/2024 10:49, Bartosz Golaszewski wrote:


If you have CONFIG_OF enabled then of_platform_populate() will go the
normal path and actually try to populate sub-nodes of the host bridge
node. If there are no OF nodes (not a device-tree system) then it will
fail.

Bart


So how about keep both patches then?


No, it doesn't make sense. If CONFIG_OF is enabled then -ENODEV is a
valid error. I was wrong to apply the previous patch as it would lead
to hiding actual errors on OF-enabled systems.

Bart


Got it; thanks.

References:
- [PATCH v2] pci: bus: only call of_platform_populate() if CONFIG_OF is enabled
  - From: Bert Karwatzki
- Re: [PATCH v2] pci: bus: only call of_platform_populate() if CONFIG_OF is enabled
  - From: Lukas Wunner
- Re: [PATCH v2] pci: bus: only call of_platform_populate() if CONFIG_OF is enabled
  - From: Krzysztof Wilczyński
- Re: [PATCH v2] pci: bus: only call of_platform_populate() if CONFIG_OF is enabled
  - From: Bartosz Golaszewski
- Re: [PATCH v2] pci: bus: only call of_platform_populate() if CONFIG_OF is enabled
  - From: Krzysztof Wilczyński
- Re: [PATCH v2] pci: bus: only call of_platform_populate() if CONFIG_OF is enabled
  - From: Mario Limonciello
- Re: [PATCH v2] pci: bus: only call of_platform_populate() if CONFIG_OF is enabled
  - From: Bartosz Golaszewski
- Re: [PATCH v2] pci: bus: only call of_platform_populate() if CONFIG_OF is enabled
  - From: Manivannan Sadhasivam
- Re: [PATCH v2] pci: bus: only call of_platform_populate() if CONFIG_OF is enabled
  - From: Mario Limonciello
- Re: [PATCH v2] pci: bus: only call of_platform_populate() if CONFIG_OF is enabled
  - From: Bartosz Golaszewski
- Re: [PATCH v2] pci: bus: only call of_platform_populate() if CONFIG_OF is enabled
  - From: Mario Limonciello
- Re: [PATCH v2] pci: bus: only call of_platform_populate() if CONFIG_OF is enabled
  - From: Bartosz Golaszewski

Prev by Date: Re: [PATCH v2] pci: bus: only call of_platform_populate() if CONFIG_OF is enabled
Next by Date: Re: [PATCH v6 09/10] PCI: imx6: Call: Common PHY API to set mode, speed, and submode
Previous by thread: Re: [PATCH v2] pci: bus: only call of_platform_populate() if CONFIG_OF is enabled
Next by thread: Re: [PATCH v2] pci: bus: only call of_platform_populate() if CONFIG_OF is enabled
Index(es):
- Date
- Thread

[Index of Archives] [DMA Engine] [Linux Coverity] [Linux USB] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI] [Greybus]