Re: [PATCH v3 3/3] PCI/NPEM: Add _DSM PCIe SSD status LED management

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +struct dsm_output {
> +	u16 status;
> +	u8 function_specific_err;
> +	u8 vendor_specific_err;
> +	u32 state;
> +} __packed;

This structure is naturally aligned, so no need for the __packed.

Otherwise looks good (or at least as good as something can look while
interacting with the weirdo ACPI interfaces..):

Reviewed-by: Christoph Hellwig <hch@xxxxxx>




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux