> +struct dsm_output { > + u16 status; > + u8 function_specific_err; > + u8 vendor_specific_err; > + u32 state; > +} __packed; This structure is naturally aligned, so no need for the __packed. Otherwise looks good (or at least as good as something can look while interacting with the weirdo ACPI interfaces..): Reviewed-by: Christoph Hellwig <hch@xxxxxx>