Re: [PATCH 00/47] arm64: qcom: dts: add QCS9100 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 7/3/2024 12:45 PM, Krzysztof Kozlowski wrote:
On 03/07/2024 05:56, Tengfei Fan wrote:
Introduce support for the QCS9100 SoC device tree (DTSI) and the
QCS9100 RIDE board DTS. The QCS9100 is a variant of the SA8775p.
While the QCS9100 platform is still in the early design stage, the
QCS9100 RIDE board is identical to the SA8775p RIDE board, except it
mounts the QCS9100 SoC instead of the SA8775p SoC.

The same huge patchset, to huge number of recipients was sent twice.
First, sorry, this is way too big. Second, it has way too many
recipients, but this is partially a result of first point. Only
partially because you put here dozen of totally unrelated emails. Sorry,
that does not make even sense. See form letter at the end how this
works. Third, sending it to everyone twice is a way to annoy them off
twice... Fourth,

Please split your work and do not cc dozen of unrelated folks.

I can split this patch series, there are two options for splitting:
Option A:
1. Initial qcs9100.dtsi, qcs9100-pmics.dtsi, qcs9100-ride.dts renamed from sa8775p with existing compatible.

2. Each subsystem have single patch series to each limited driver maintainers.

- About 15 series need to update related drivers, so each series will have 3 patches (bindings, drivers, the compatible names in subsystem-related parts of dtsi/dts).

- About 14 series only need to add qcs9100 compatible in bindings., so each series will have 2 patches (bindings, the compatible names in subsystem-related parts of dtsi/dts).

Option B:

1. Each subsystem have single patch series to each limited driver maintainers. Each patch series only update bindings, drivers, but no compatible names change in dts.

- About 15 series in total and each series will have 2 patches (bindings, drivers).

- About 14 series only need to add qcs9100 compatible in bindings, so each series will have 1 patches (bindings).

2. Squash current qcs9100.dtsi, qcs9100-pmics.dtsi, qcs9100-ride.dts with compatible changed to qcs9100 dt files.

We tend to use Option A.

Welcome to other ideas ideas for splitting the huge numbers of patches as well.

Another, each splited series will also have cover letter contain the whole story like this cover letter.


<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline), work on fork of kernel
(don't, instead use mainline) or you ignore some maintainers (really
don't). Just use b4 and everything should be fine, although remember
about `b4 prep --auto-to-cc` if you added new patches to the patchset.
</form letter>

Best regards,
Krzysztof


Previously, I've been using scripts/get_maintainers.pl to obtain a list of recipients and manually removing duplicate email addresses(although I noticed you have two different email addresses, so I included both). I'll follow your advice and use b4 to submit a new version patch series to upstream, confident that similar issues won't arise again.

--
Thx and BRs,
Tengfei Fan




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux