On Tue, Jul 2, 2024 at 7:33 PM <superm1@xxxxxxxxxx> wrote:
>
> From: Mario Limonciello <mario.limonciello@xxxxxxx>
>
> commit 8fb18619d910 ("PCI/pwrctl: Create platform devices for child OF
> nodes of the port node") introduced a new error message about populating
> OF nodes. This message isn't relevant on non-OF platforms, so downgrade
> it to debug instead.
>
> Cc: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> Cc: Amit Pundir <amit.pundir@xxxxxxxxxx>
> Cc: Neil Armstrong <neil.armstrong@xxxxxxxxxx> # on SM8550-QRD, SM8650-QRD & SM8650-HDK
> Cc: Caleb Connolly <caleb.connolly@xxxxxxxxxx> # OnePlus 8T
> Reported-by: Praveenkumar Patil <PraveenKumar.Patil@xxxxxxx>
> Fixes: 8fb18619d910 ("PCI/pwrctl: Create platform devices for child OF nodes of the port node")
> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
> ---
> drivers/pci/bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/bus.c b/drivers/pci/bus.c
> index e4735428814d..f21c4ec979b5 100644
> --- a/drivers/pci/bus.c
> +++ b/drivers/pci/bus.c
> @@ -354,7 +354,7 @@ void pci_bus_add_device(struct pci_dev *dev)
> retval = of_platform_populate(dev->dev.of_node, NULL, NULL,
> &dev->dev);
> if (retval)
> - pci_err(dev, "failed to populate child OF nodes (%d)\n",
> + pci_dbg(dev, "failed to populate child OF nodes (%d)\n",
> retval);
> }
> }
> --
> 2.43.0
>
>
Ah! I was under the impression that of_platform_populate() would
return 0 with !OF but it returns -ENODEV instead...
Maybe do:
if (retval && retval != -ENODEV) and keep pci_err() here?
Bart
