> On Thu, Jun 27, 2024 at 10:12:11AM +0200, Lorenzo Bianconi wrote: > > Introduce Airoha EN7581 entry in mediatek-gen3 PCIe controller binding > > > > Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx> > > --- > > .../bindings/pci/mediatek-pcie-gen3.yaml | 68 +++++++++++++++++-- > > 1 file changed, 63 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > index 76d742051f73..59112adc9ba1 100644 > > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > @@ -53,6 +53,7 @@ properties: > > - mediatek,mt8195-pcie > > - const: mediatek,mt8192-pcie > > - const: mediatek,mt8192-pcie > > + - const: airoha,en7581-pcie > > > > reg: > > maxItems: 1 > > @@ -76,20 +77,20 @@ properties: > > > > resets: > > minItems: 1 > > - maxItems: 2 > > + maxItems: 3 > > > > reset-names: > > minItems: 1 > > - maxItems: 2 > > + maxItems: 3 > > items: > > - enum: [ phy, mac ] > > + enum: [ phy, mac, phy-lane0, phy-lane1, phy-lane2 ] > > > > clocks: > > - minItems: 4 > > + minItems: 1 > > maxItems: 6 > > > > clock-names: > > - minItems: 4 > > + minItems: 1 > > maxItems: 6 > > > > assigned-clocks: > > @@ -147,6 +148,9 @@ allOf: > > const: mediatek,mt8192-pcie > > then: > > properties: > > + clocks: > > + maxItems: 6 > > + > > clock-names: > > items: > > - const: pl_250m > > @@ -155,6 +159,15 @@ allOf: > > - const: tl_32k > > - const: peri_26m > > - const: top_133m > > + > > + resets: > > + minItems: 1 > > + maxItems: 2 > > + > > + reset-names: > > + minItems: 1 > > + maxItems: 2 > > + > > - if: > > properties: > > compatible: > > @@ -164,6 +177,9 @@ allOf: > > - mediatek,mt8195-pcie > > then: > > properties: > > + clocks: > > + maxItems: 6 > > How come this is maxItems and not minItems? The max is always 6, before > and after your patch. ack, I will fix in v3 Regards, Lorenzo > > Cheers, > Conor.
Attachment:
signature.asc
Description: PGP signature
