On Fri, 28 Jun 2024 23:24:56 +0100, Catalin Marinas <catalin.marinas@xxxxxxx> wrote: > > Hi Thomas, > > On Sun, Jun 23, 2024 at 05:18:39PM +0200, Thomas Gleixner wrote: > > From: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > > > > The its_pci_msi_prepare() function from the ITS-PCI/MSI code provides the > > 'global' PCI/MSI domains. Move this function to the ITS-MSI parent code and > > amend the function to use the domain hardware size, which is the MSI[X] > > vector count, for allocating the ITS slots for the PCI device. > > > > Enable PCI matching in msi_parent_ops and provide the necessary update to > > the ITS specific child domain initialization function so that the prepare > > callback gets invoked on allocations. > > > > The latter might be optimized to do the allocation right at the point where > > the child domain is initialized, but keep it simple for now. > > > > Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > > Signed-off-by: Anna-Maria Behnsen <anna-maria@xxxxxxxxxxxxx> > > Signed-off-by: Shivamurthy Shastri <shivamurthy.shastri@xxxxxxxxxxxxx> > > Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > > I just noticed guests (under KVM) failing to boot on my TX2 with your > latest branch. I bisected to this patch as the first bad commit. Reproduced here on a different host (M1), so this is not specific to TX2 (which would have been odd since KVM emulates the ITS entirely). I'll start digging. M. -- Without deviation from the norm, progress is not possible.