Re: [pci:controller/rockchip 10/11] drivers/pci/controller/dwc/pcie-designware-ep.c:26:undefined reference to `pci_epc_init_notify'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

[...]
> > All errors (new ones prefixed by >>):
> > 
> >    loongarch64-linux-ld: drivers/pci/controller/dwc/pcie-designware-ep.o: in function `dw_pcie_ep_init_notify':
> > >> drivers/pci/controller/dwc/pcie-designware-ep.c:26:(.text+0x1e4): undefined reference to `pci_epc_init_notify'
> 
> Seeing that it is pcie-designware-ep.c that fails to build, I can see the error.
> I have forgotten to do:
> 
> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index 9c4fb8ba7573..4c38181acffa 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -329,6 +329,7 @@ config PCIE_ROCKCHIP_DW_EP
>         bool "Rockchip DesignWare PCIe controller (endpoint mode)"
>         depends on ARCH_ROCKCHIP || COMPILE_TEST
>         depends on OF
> +       depends on PCI_ENDPOINT
>         select PCIE_DW_EP
>         select PCIE_ROCKCHIP_DW
>         help
> 
> (The .config in this build has PCIE_ROCKCHIP_DW_EP selected, but not PCI_ENDPOINT,
> which should not be allowed...)
> 
> This is my fault, all the other endpoint drivers have a depends on PCI_ENDPOINT.
> Will send a patch for this shortly. I'm truly sorry for this mistake.

No worries.  Thank you for a quick fix!  Much appreciated.

	Krzysztof




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux