On Sat, Jun 22, 2024 at 04:39:37AM +0900, Krzysztof Wilczyński wrote: > Hello, > > [...] > > If there is anything more I can do to get this picked up, please tell me. > > Looks good! As such... > > Applied to controller/rockchip, thank you! > > [01/04] PCI: dw-rockchip: Fix weird indentation > https://git.kernel.org/pci/pci/c/e7e8872191af > > [02/04] PCI: dw-rockchip: Add rockchip_pcie_get_ltssm() helper > https://git.kernel.org/pci/pci/c/cbb2d4ae3fdc > > [03/04] PCI: dw-rockchip: Add endpoint mode support > https://git.kernel.org/pci/pci/c/67fe449bcd85 > > [04/04] PCI: dw-rockchip: Refactor the driver to prepare for EP mode > https://git.kernel.org/pci/pci/c/ecdc98a3a912 Krzysztof, unfortunately, the controller/rockchip branch currently doesn't build: drivers/pci/controller/dwc/pcie-dw-rockchip.c: In function ‘rockchip_pcie_ep_sys_irq_thread’: drivers/pci/controller/dwc/pcie-dw-rockchip.c:407:17: error: implicit declaration of function ‘dw_pcie_ep_linkdown’; did you mean ‘dw_pcie_ep_linkup’? [-Wimplicit-function-declaration] 407 | dw_pcie_ep_linkdown(&pci->ep); | ^~~~~~~~~~~~~~~~~~~ | dw_pcie_ep_linkup Could you possibly include the commit: 3d2e425263e2 ("PCI: dwc: ep: Add a generic dw_pcie_ep_linkdown() API to handle Link Down event") from the controller/dwc branch in the controller/rockchip as well, or rebase the controller/rockchip branch on top of the controller/dwc branch, or merge the controller/dwc branch to the controller/rockchip branch? Additionally, since you picked up Mani's series which removes dw_pcie_ep_init_notify() on the controller/dwc branch: 9eba2f70362f ("PCI: dwc: ep: Remove dw_pcie_ep_init_notify() wrapper") You will need to pick up this patch as well: https://lore.kernel.org/linux-pci/20240622132024.2927799-2-cassel@xxxxxxxxxx/T/#u Otherwise there will be a build error when merging the controller/dwc and the controller/rockchip branch to for-next. The patch that I sent out can be picked up to the controller/rockchip right now (since the API that Mani is switching to already exists in Linus's tree). May I ask why all the branches for the different DWC glue drivers are not based on the controller/dwc branch? They are obviously going to be tightly related. Kind regards, Niklas
