On Fri, Jun 21, 2024 at 12:14:20PM +0530, Anand Moon wrote: > Refactors the clock handling in the Rockchip PCIe driver, > introducing a more robust and efficient method for enabling and > disabling clocks using clk_bulk*() API. Using the clk_bulk APIs, > the clock handling for the core clocks becomes much simpler. > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Closes: https://lore.kernel.org/oe-kbuild-all/202406200818.CQ7DXNSZ-lkp@xxxxxxxxx/ Drop these two lines, as suggested in the test robot report: If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags ... This is a new version of the same patch, so it doesn't need those tags. The problem you're solving with this patch is that the clock handling is too complicated. The test robot didn't report *that* problem. Since you'll repost for this, also s/Refactors/Refactor/ in the commit log so this is in imperative mood: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v6.9#n94 https://chris.beams.io/posts/git-commit/ > drivers/pci/controller/pcie-rockchip.c | 64 ++++---------------------- > drivers/pci/controller/pcie-rockchip.h | 15 ++++-- > 2 files changed, 21 insertions(+), 58 deletions(-) Nice reduction in lines!
