On Wed, May 23, 2012 at 1:03 AM, Amos Kong <kongjianjun@xxxxxxxxx> wrote:
> On Wed, May 23, 2012 at 1:29 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>> On Tue, May 22, 2012 at 10:15 PM, Amos Kong <kongjianjun@xxxxxxxxx> wrote:
>>> Attached the v7, test passed.
>>
>> would be better to have break...
>
> Yeah. Otherwise, it will delete from the last function.
> Attached v8, test passed.
>
>
>> +static struct pci_dev *dev_in_slot(struct acpiphp_slot *slot)
>> +{
>> + struct pci_bus *bus = slot->bridge->pci_bus;
>> + struct pci_dev *dev;
>> + int ret = NULL;
>> +
>> + down_read(&pci_bus_sem);
>> + list_for_each_entry(dev, &bus->devices, bus_list)
>> + if (PCI_SLOT(dev->devfn) == slot->device)
>> + ret = pci_dev_get(dev);
>> + up_read(&pci_bus_sem);
>> +
>> + return ret;
>> +}
>>
>> ===>
>>
>>
>> +static struct pci_dev *dev_in_slot(struct acpiphp_slot *slot)
>> +{
>> + struct pci_bus *bus = slot->bridge->pci_bus;
>> + struct pci_dev *dev;
>> + int ret = NULL;
>> +
>> + down_read(&pci_bus_sem);
>> + list_for_each_entry(dev, &bus->devices, bus_list)
>> + if (PCI_SLOT(dev->devfn) == slot->device) {
>> + ret = pci_dev_get(dev);
>> + break;
>> + }
>> + up_read(&pci_bus_sem);
>> +
>> + return ret;
>> +}
I applied the v6 1/2 and this v8 patch to my "for-3.6" branch.
Thanks for fixing this, Amos! It's another step towards rationalizing
all the hotplug drivers we have.
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
