On Fri, Jun 14 2024 at 11:09, Bjorn Helgaas wrote: > On Fri, Jun 14, 2024 at 12:23:42PM +0200, Shivamurthy Shastri wrote: >> Most ARM(64) PCI/MSI domains mask and unmask in the parent domain after or >> before the PCI mask/unmask operation takes place. So there are more than a >> dozen of the same wrapper implementation all over the place. > > Is this an opportunity to clean up all these wrappers? If you could > mention an example or two here, maybe somebody would be motivated to > come back and simplify the existing wrappers to take advantage of this > new flag? The wrappers go away once the relevant MSI implementations are converted over to the new scheme/ See patch 7 for an example: its_[un]mask_msi_irq() are gone. Thanks, tglx