On Thu, May 23, 2024 at 12:24:48PM +0100, Jonathan Cameron wrote: > What happens if multiple DOE which support the same protocol? > (IIRC that's allowed). You probably need to paper over repeat > sysfs attributes and make sure they don't get double freed etc. So I believe this was fixed in v11 but assuming the point here is to allow lspci to display supported protocols without speaking DOE with the device, the way it's implemented now user space cannot discern which mailbox supports which protocol. Or if multiple mailboxes support the same protocol. I'm wondering in how far that limits the usefulness of the feature. sysfs doesn't support nested groups. But we could dynamically create one attribute group per mailbox. Or have one file per mailbox in a common doe_features group, each file containing all the supported protocols. Hm... Thanks, Lukas
