On Fri, 14 Jun 2024 10:12:42 +1000 Alistair Francis <alistair23@xxxxxxxxx> wrote: > PCIe r6.1 (which was published July 24) describes a "Vendor ID", a > "Data Object Type" and "Next Index" as the fields in the DOE > Discovery Response Data Object. The DOE driver currently uses > both the terms type and prot for the second element. > > This patch renames all uses of the DOE Discovery Response Data Object > to use type as the second element of the object header, instead of > type/prot as it currently is. > > Signed-off-by: Alistair Francis <alistair.francis@xxxxxxx> Completely trivial suggestion below Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h > index 94c00996e633..ca692a3e1e5e 100644 > --- a/include/uapi/linux/pci_regs.h > +++ b/include/uapi/linux/pci_regs.h > @@ -1146,9 +1146,12 @@ > #define PCI_DOE_DATA_OBJECT_DISC_REQ_3_INDEX 0x000000ff > #define PCI_DOE_DATA_OBJECT_DISC_REQ_3_VER 0x0000ff00 > #define PCI_DOE_DATA_OBJECT_DISC_RSP_3_VID 0x0000ffff > -#define PCI_DOE_DATA_OBJECT_DISC_RSP_3_PROTOCOL 0x00ff0000 > +#define PCI_DOE_DATA_OBJECT_DISC_RSP_3_TYPE 0x00ff0000 > #define PCI_DOE_DATA_OBJECT_DISC_RSP_3_NEXT_INDEX 0xff000000 > > +/* Deprecated old name, replaced with PCI_DOE_DATA_OBJECT_DISC_RSP_3_TYPE */ > +#define PCI_DOE_DATA_OBJECT_DISC_RSP_3_PROTOCOL 0x00ff0000 I don't care that much, but could make one define just use the other so the code makes it explicit that this is just a rename. > + > /* Compute Express Link (CXL r3.1, sec 8.1.5) */ > #define PCI_DVSEC_CXL_PORT 3 > #define PCI_DVSEC_CXL_PORT_CTL 0x0c
