On Thu, 2024-06-13 at 16:06 -0500, Bjorn Helgaas wrote: > On Thu, Jun 13, 2024 at 01:50:23PM +0200, Philipp Stanner wrote: > > pci_intx() is one of the functions that have "hybrid mode" (i.e., > > sometimes managed, sometimes not). Providing a separate pcim_intx() > > function with its own device resource and cleanup callback allows > > for > > removing further large parts of the legacy PCI devres > > implementation. > > > > As in the region-request-functions, pci_intx() has to call into its > > managed counterpart for backwards compatibility. > > > > As pci_intx() is an outdated function, pcim_intx() shall not be > > made > > visible to drivers via a public API. > > What makes pci_intx() outdated? If it's outdated, we should mention > why and what the 30+ callers (including a couple in drivers/pci/) > should use instead. That is 100% based on Andy Shevchenko's (+CC) statement back from January 2024 a.D. [1] Apparently INTx is "old IRQ management" and should be done through pci_alloc_irq_vectors() nowadays. [1] https://lore.kernel.org/all/ZabyY3csP0y-p7lb@surfacebook.localdomain/ P. > > Bjorn >
