Re: [PATCH net-next v10 2/7] net: tn40xx: add pci driver for Tehuti Networks TN40xx chips

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 13 Jun 2024 17:25:22 -0700
Jakub Kicinski <kuba@xxxxxxxxxx> wrote:

> On Tue, 11 Jun 2024 13:52:12 +0900 FUJITA Tomonori wrote:
>> This just adds the scaffolding for an ethernet driver for Tehuti
>> Networks TN40xx chips.
> 
> Reviewed-by: Jakub Kicinski <kuba@xxxxxxxxxx>

Thanks a lot!

> Minor notes below
> 
>> +TEHUTI TN40XX ETHERNET DRIVER
>> +M:	FUJITA Tomonori <fujita.tomonori@xxxxxxxxx>
>> +L:	netdev@xxxxxxxxxxxxxxx
>> +S:	Supported
> 
> Keep in mind that Supported will soon mean you gotta run a test farm ;)
> https://netdev.bots.linux.dev/devices.html

I overlooked that. I change the status to "Maintained" in the next version.

>> +MODULE_DEVICE_TABLE(pci, tn40_id_table);
>> +MODULE_AUTHOR("Tehuti networks");
> 
> I don't see sign-offs from anyone else, so you can either put yourself
> as the author or just leave it out. People write code, not corporations.
> IOW authorship != copyright.

Understood. I'll leave it out.




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux