Re: [PATCH v2] PCI: use local_pci_probe when best selected cpu is offline

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Markus,
  Thanks for your review.

On 2024/6/13 上午2:08, Markus Elfring wrote:
This can be happen if a node is online while all its CPUs are offline
(we can use "maxcpus=1" without "nr_cpus=1" to reproduce it), Therefore,
in this case, we should call local_pci_probe() instead of work_on_cpu().

* Please take text layout concerns a bit better into account also according to
   the usage of paragraphs.
   https://elixir.bootlin.com/linux/v6.10-rc3/source/Documentation/process/maintainer-tip.rst#L128OK, Let rewrite the commit message.
* Please improve the change description with an imperative wording.
   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc3#n94
OK, Let me use imperative word.
* Would you like to add the tag “Fixes” accordingly?
OK, Let me add Fixes.
* How do you think about to specify the name of the affected function
   in the summary phrase?
OK, Let me add the affected function in summary phrase.


Regards,
Markus



--
Best Regards
Hongchen Zhang





[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux