On Wed, May 29, 2024 at 10:28:59AM +0200, Niklas Cassel wrote: > The descriptions of the combined interrupt signals (level1) mention > all the lower interrupt signals (level2) for each combined interrupt, > regardless if the lower (level2) signal is RC or EP specific. > > E.g. the description of "Combined system interrupt" includes rbar_update, > which is EP specific, and the description of "Combined message interrupt" > includes obff_idle, obff_obff, obff_cpu_active, which are all EP specific. > > The only exception is the "Combined legacy interrupt", which for some > reason does not provide an exhaustive list of the lower (level2) signals. > > Add the missing lower interrupt signals: tx_inta, tx_intb, tx_intc, and > tx_intd for the "Combined legacy interrupt", as per the rk3568 and rk3588 > Technical Reference Manuals, such that the descriptions of the combined > interrupt signals are consistent. > > Signed-off-by: Niklas Cassel <cassel@xxxxxxxxxx> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> - Mani > Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx> > --- > Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml > index 60d190a77580..ec5e6a3d048e 100644 > --- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml > +++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml > @@ -56,7 +56,8 @@ properties: > pm_pme, pm_to_ack, pm_turnoff, obff_idle, obff_obff, obff_cpu_active > - description: > Combined legacy interrupt, which is used to signal the following > - interrupts - inta, intb, intc, intd > + interrupts - inta, intb, intc, intd, tx_inta, tx_intb, tx_intc, > + tx_intd > - description: > Combined error interrupt, which is used to signal the following > interrupts - aer_rc_err, aer_rc_err_msi, rx_cpl_timeout, > > -- > 2.45.1 > -- மணிவண்ணன் சதாசிவம்
