On Wed, May 29, 2024 at 04:54:57PM +0200, Niklas Cassel wrote: > ... > We should probably also address Bjorn comment: > "ls and qcom even use *both*: pci_epc_linkdown() but dw_pcie_ep_linkup()." > > As far as I can tell, it is only ls (not sure why Bjorn also mentioned qcom): > drivers/pci/controller/dwc/pci-layerscape-ep.c: pci_epc_linkdown(pci->ep.epc); > But this should probably also be fixed to use dw_pcie_ep_linkdown(). qcom_pcie_ep_global_irq_thread() calls both pci_epc_linkdown() and dw_pcie_ep_linkup(): https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pci/controller/dwc/pcie-qcom-ep.c?id=v6.10-rc1#n628
