Prarit Bhargava <prarit <at> redhat.com> writes:
> /**
> diff --git a/drivers/pci/pcie/aer/aerdrv.c b/drivers/pci/pcie/aer/aerdrv.c
> index 58ad791..dd6b352 100644
> --- a/drivers/pci/pcie/aer/aerdrv.c
> +++ b/drivers/pci/pcie/aer/aerdrv.c
> @@ -346,6 +346,9 @@ static pci_ers_result_t aer_root_reset(struct pci_dev *dev)
> u32 reg32;
> int pos;
>
> + if (dev->rp_AER_panic)
> + panic("%s: AER detected on Root Port", pci_name(dev));
> +
> pos = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_ERR);
>
I really like this idea. I just wonder if the panic can happen in do_recovery in
aerdrv_core.c before the broadcast_error_message() is done that invokes all of
the error_detected callbacks. It would be best to panic as soon as possible to
increase error containment.
If we don't move it to before the broadcast_error_message(), I was also looking
at if it would be appropriate to put the check for this in the
default_downstream_reset_link() in aerdrv_core.c too. What do you think?
-Betty Dall
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
