On 05/17/2012 01:29 PM, Shyam_Iyer@xxxxxxxx wrote: > > >> -----Original Message----- >> From: linux-pci-owner@xxxxxxxxxxxxxxx [mailto:linux-pci- >> owner@xxxxxxxxxxxxxxx] On Behalf Of Prarit Bhargava >> Sent: Thursday, May 17, 2012 1:05 PM >> To: linux-pci@xxxxxxxxxxxxxxx >> Cc: Prarit Bhargava; Bjorn Helgaas >> Subject: [PATCH] pci, Add AER_panic sysfs file >> >> Consider the following case >> >> [ RP ] >> | >> | >> +---------+-----------+ >> | | | >> [H1] [H2] [X1] >> >> where RP is a PCIE Root Port, H1 and H2 are devices with drivers that >> support >> PCIE AER driver error handling (ie, they have pci_error_handlers >> defined in >> the driver), and X1 is a device with a driver that does not support >> PCIE >> AER driver error handling. >> >> If the Root Port takes an error what currently happens is that the >> bus resets and H1 & H2 call their slot_reset functions. X1 does >> nothing. >> >> In some cases a user may not wish the system to continue because X1 is >> an unhardened driver. In these cases, the system should not do a bus >> reset, >> but rather the system should panic to avoid any further possible data >> corruption. > > Do we neeed to panic for both correctable and uncorrectable errors.. ? > > I thought correctable errors could recover without a bus reset. Will a bus reset be issued on a correctable error? I thought the code path was that the bus reset was issued on the uncorrectable error. drivers/pci/pcie/aer/aerdrv_core.c: do_recovery() if (severity == AER_FATAL) { result = reset_link(dev); if (result != PCI_ERS_RESULT_RECOVERED) goto failed; } I may not be looking at the right spot of code. Care to enlighten me? :) P. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
