On Mon, May 06, 2024 at 02:10:24PM +0200, Linus Walleij wrote: > On Mon, Apr 29, 2024 at 12:25 PM Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > > The of_gpio.h is going to be removed. In preparation of that convert > > the driver to the agnostic API. > > > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > > Reviewed-by: Frank Li <Frank.Li@xxxxxxx> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > I think there is a bug here, the code is respecting the OF property > "reset-gpio-active-high" > but the code in drivers/gpio/gpiolib-of.h actually has a quirk for > this so you can just > delete all the active high handling and rely on 1 = asserted and 0 = > deasserted when > using GPIO descriptors. > Wow... So this bug is present even before this series, right? > Just delete this thing: > imx6_pcie->gpio_active_high = of_property_read_bool(node, > "reset-gpio-active-high"); But this is just a bandaid IMO. The flag for the PERST# GPIO should be properly set in the board dts as per the board design. - Mani -- மணிவண்ணன் சதாசிவம்
