> > If (!ide_cap && tee_cap), we get here but doing the below does not make > > sense for TEE (which are likely to be VFs). > > The "!ide_cap && tee_cap" case may also be the "TSM wants to setup IDE > without TDISP flow". IIUC, should be "TSM wants to setup TDISP without IDE flow"? But I think aik is talking about VFs (which fit "!ide_cap && tee_cap"), VFs should not be rejected by the following: pci_tsm->doe_mb = pci_find_doe_mailbox(pdev, PCI_VENDOR_ID_PCI_SIG, PCI_DOE_PROTO_CMA); if (!pci_tsm->doe_mb) return; VF should check its PF's doe/ide/tee cap and then be added to pci_tsm_devs, is it? Thanks, Yilun