Re: [PATCH 2/4] PCI: pciehp: bail out if pci_hp_add_bridge() fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Fri, May 03, 2024 at 04:23:41PM -0500, Bjorn Helgaas wrote:
> On Fri, May 03, 2024 at 09:23:20PM +0200, Nam Cao wrote:
> > If there is no bus number available for the downstream bus of the
> > hot-plugged bridge, pci_hp_add_bridge() will fail. The driver proceeds
> > regardless, and the kernel crashes.
> > 
> > Abort if pci_hp_add_bridge() fails.
> Thanks for this and for the details in the cover letter.  The cover
> letter doesn't get directly preserved and connected to the git commit,
> so please include some of the details here in the commit log.
> I don't think we need *everything* from the cover letter; just enough
> of the messages to show what went wrong and how the kernel crashed, so
> somebody who trips over this can connect the crash with this fix.  And
> the timestamps are not relevant, so you can strip them out.  The qemu
> repro case is useful too, thanks for that!
> Same for the shpchp patch.
> And use "git log --oneline drivers/pci/hotplug/pciehp_pci.c" and match
> the formatting (in particular, the capitalization) of your subject
> lines.

Thanks for the detailed instructions. I will send v2 next week.

Best regards,

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux