On Thu, May 02, 2024 at 11:12:43AM +0100, Sudeep Holla wrote: > On Thu, May 02, 2024 at 03:32:25PM +0530, Sunil V L wrote: > > On Thu, May 02, 2024 at 12:24:14PM +0300, Andy Shevchenko wrote: > > > On Wed, May 01, 2024 at 05:47:28PM +0530, Sunil V L wrote: > > > > Add a new function for RISC-V to do any architecture specific > > > > initialization. This function will be used to create platform devices > > > > like APLIC, PLIC, RISC-V IOMMU etc. This is similar to acpi_arm_init(). > > > > > > What is the special about this architecture that it requires a separate > > > initialization that is _not_ going to be in other cases? > > > Please, elaborate. > > > > > This init function will be used to create GSI mapping structures and in > > future may be others like iommu. Like I mentioned, ARM already has > > similar function acpi_arm_init(). So, it is not new right? > > Just to add: > > This is to initialise everything around all the arch specific tables > which you will not have on any other architectures. We could execute > on all architectures but the tables will never be found. The main point > is why do we want to do that if we can optimise and skip on all other > archs. You need to carefully write the commit messages. Some kind of the above paragraphs has to be in there. -- With Best Regards, Andy Shevchenko
