On Wed, May 01, 2024 at 02:55:34PM -0500, Bjorn Helgaas wrote: > On Wed, May 01, 2024 at 07:51:18AM -0700, Keith Busch wrote: > > From: Keith Busch <kbusch@xxxxxxxxxx> > > > > After a link reset, the Broadcom / LSI PEX890xx PCIe Gen 5 Switch in synth > > mode will temporarily insert a fake place-holder device, 1000 02b2, before > > the link is actually active for the expected downstream device. Confirm > > the device's identifier matches what we expect before moving forward. > > Otherwise, the pciehp driver may unmask hotplug notifications before > > the link is actually active, which triggers an undesired device removal. > > Is this a Switch that doesn't conform to the PCIe spec, or is there > something wrong with the way we're looking for a CRS completion? > > In the absence of a device defect, I would not expect to need a > Broacom-specific comment in this code. Yeah, you're right. I started off quirking specific devices, then it evolved to the more generic handling this turned into, but didn't update the commit log or comments accordingly.
