On 01/05/2024 17:43, mr.nuke.me@xxxxxxxxx wrote: > On 5/1/24 5:21 AM, Krzysztof Kozlowski wrote: >> On 01/05/2024 06:28, Alexandru Gagniuc wrote: >>> IPQ9574 has four PCIe controllers: two single-lane Gen3, and two >>> dual-lane Gen3. The controllers are identical from a software >>> perspective, with the differences appearing in the PHYs. >>> >>> Add a compatible for the PCIe on IPQ9574. >> >> This is a friendly reminder during the review process. >> >> It looks like you received a tag and forgot to add it. >> >> If you do not know the process, here is a short explanation: >> Please add Acked-by/Reviewed-by/Tested-by tags when posting new >> versions, under or above your Signed-off-by tag. Tag is "received", when >> provided in a message replied to you on the mailing list. Tools like b4 >> can help here. However, there's no need to repost patches *only* to add >> the tags. The upstream maintainer will do that for tags received on the >> version they apply. >> >> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 >> >> If a tag was not added on purpose, please state why and what changed. > > I had an Acked-by tag from Rob for what is now patch 6/8 -- previously > 5/7. Due to last-minute info from QUIC Inc, Dmitry and I decided to move > the "snoc" and "anoc" clocks out of the PHY and to the PCIe controller. > > This change resulted in a 6/8 patch that is substantially different from > what Rob acked. I felt it was inappropriate to keep the tag. So please read my message again: "If a tag was not added on purpose, please state why and what changed." Your changelog for that patch should say that. Best regards, Krzysztof
