On Mon, 29 Apr 2024, Andrew Lunn wrote: > On Mon, Apr 29, 2024 at 01:46:24PM +0300, Ilpo Järvinen wrote: > > orion5x defines PCI_CONF_REG() and PCI_CONF_FUNC() that are problematic > > because PCI core is going to introduce defines with the same names. > > > > Add ORION5X prefix to those defines to avoid name conflicts. > > > > Note: as this is part of series that replaces the code in question > > anyway, only bare minimum renaming is done and other similarly named > > macros are not touched. > > > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> > > Hi Ilpo > > What branch do these apply to? I wanted to test them, but i get hunks > rejected: > > git am < 20240429104633.11060-1-ilpo.jarvinen@xxxxxxxxxxxxxxxxxxx > Applying: ARM: orion5x: Rename PCI_CONF_{REG,FUNC}() out of the way > Applying: ARM: orion5x: Use generic PCI Conf Type 1 helper > error: patch failed: arch/arm/mach-orion5x/pci.c:276 > error: arch/arm/mach-orion5x/pci.c: patch does not apply > Patch failed at 0002 ARM: orion5x: Use generic PCI Conf Type 1 helper > > I tried linux-next, v6.9-rc6, pci:next Hi, On top of pci:main (so v6.9-rc1). "ARM: orion5x: Use generic PCI Conf Type 1 helper" should be only 4th patch but your command seems to apply it as 2nd patch (is the mbx file having them out-of-order?). -- i.