On Sat, Apr 27, 2024 at 12:53:35PM +0530, Manivannan Sadhasivam wrote: > On Tue, Apr 23, 2024 at 08:19:07PM +0300, Andy Shevchenko wrote: > > The of_gpio.h is going to be removed. In preparation of that convert > > the driver to the agnostic API. ... > > + pcie->id_clkreq_gpio[i] = devm_gpiod_get_index(dev, > > + "hisilicon,clken", i, > > + GPIOD_ASIS); > > Please don't use GPIOD_ASIS even if the old code was using it. > > For all 3 GPIOs in this driver, GPIOD_OUT_LOW flag should be used as the default > state is assert (considering the fact that the DT uses GPIO_ACTIVE_HIGH). And if not? I believe we may not assume that all of DTBs around the globe put the flags correctly. But I think you know much more about them than me, hence I am okay to update this. -- With Best Regards, Andy Shevchenko
