Re: [PATCH] PCI: tegra194: Set address alignment for endpoint mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 26/04/2024 13:54, Niklas Cassel wrote:
On Fri, Apr 26, 2024 at 01:27:31PM +0100, Jon Hunter wrote:
Tegra194 and Tegra234 devices require that the endpoint address is
aligned on a 64kB boundary and therefore, set the endpoint address
alignment to 64kB in the Tegra194 PCIe driver.

Hello Jon,

While I think the change in this patch looks good,
I think you need to rephrase your commit message.

The 'align' of pci_epc_features represents inbound ATU constraints.
(So for BAR access.)
See Kishon reply at:
https://lore.kernel.org/linux-pci/dccb87db-d826-43fa-a499-cf36ea9b10d5@xxxxxxx/T/#m7697d1d745d8499fc6b8db855b7f93dafd7ed5b3


Thanks! I will fix up the commit message and re-send.

Jon




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux