> -----Original Message----- > From: Krzysztof Wilczyński <kwilczynski@xxxxxxxxxx> > Sent: Wednesday, February 28, 2024 10:53 PM > To: Bjorn Helgaas <helgaas@xxxxxxxxxx> > Cc: Saurabh Singh Sengar <ssengar@xxxxxxxxxxxxxxxxxxx>; > bhelgaas@xxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; alexander.stein@xxxxxxxxxxxxxxx; Dexuan Cui > <decui@xxxxxxxxxxxxx> > Subject: [EXTERNAL] Re: [PATCH] PCI/sysfs: Fix race in pci sysfs creation > > [You don't often get email from kwilczynski@xxxxxxxxxx. Learn why this is > important at https://aka.ms/LearnAboutSenderIdentification ] > > Hello, > > Sorry for late reply. > > [...] > > > > > Krzysztof has done a ton of work to convert these files to > > > > > static attributes, where the device model prevents most of these > races: > > > > > > > > > > 506140f9c06b ("PCI/sysfs: Convert "index", "acpi_index", "label" to > static attributes") > > > > > d93f8399053d ("PCI/sysfs: Convert "vpd" to static attribute") > > > > > f42c35ea3b13 ("PCI/sysfs: Convert "reset" to static attribute") > > > > > 527139d738d7 ("PCI/sysfs: Convert "rom" to static attribute") > > > > > e1d3f3268b0e ("PCI/sysfs: Convert "config" to static > > > > > attribute") > > > > > > > > > > and he even posted a series to do the same for the resource files: > > > > > > > > > > > > > > > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F% > > > > > 2Flore.kernel.org%2Flinux-pci%2F20210910202623.2293708-1- > kw%40li > > > > > > nux.com%2F&data=05%7C02%7Cssengar%40microsoft.com%7C99b036f685e > 4 > > > > > > 448ddb5408dc3881e998%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0 > % > > > > > > 7C638447377886194494%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA > wMDA > > > > > > iLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sda > > > > > > ta=TsOJsR8CQGaOrJVnw0BPm0QGL%2FAUQ0GCTuzgrN8FX%2BQ%3D&reserve > d=0 > > > > > > > > > > I can't remember why we didn't apply that at the time, and it no > > > > > longer applies cleanly, but I think that's the direction we should go. > > > > > > > > Thanks for you review. > > > > > > > > Please inform me if there's existing feedback explaining why this > > > > series hasn't been merged yet. I am willing to further improve it > > > > if necessary. > > > > > > Let us know your opinion so that we can move ahead in fixing this > > > long pending bug. > > I really thought you were asking me about your patch. So, I didn't reply > since Bjorn added his review. > > > There's no feedback on the mailing list (I checked the link above), so > > the way forward is to update the series so it applies cleanly again > > and post it as a v3. > > Start with a review, if you have some time. Perhaps we can make it better > before sending another revision. > > There are two areas which this series decided not to tackle initially: > > - Support for the Alpha platform > - Support for legacy PCI platforms > > Feel free to have a look at the above. Perhaps you will have some ideas on > how to best convert both of these to use static attributes, so that we could > convert everything at the same time. > > > There's no need to wait for Krzysztof to refresh it, and if you have > > time to do it, it would be very welcomed! The best base would be > > v6.8-rc1. > > That I can do, perhaps this coming weekend. Or even sooner when I find > some time this week. > > Krzysztof Krzysztof, Are you still planning to send the revised version for it ?
