On Thu, Apr 11, 2024 at 12:22:48PM -0400, Parker Newman wrote: > On Thu, 11 Apr 2024 17:54:45 +0200 > Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > > On Thu, Apr 11, 2024 at 11:29:26AM -0400, parker@xxxxxxxxx wrote: > > > From: Parker Newman <pnewman@xxxxxxxxxxxxxxx> > > > > > > - Added missing CTI serial car PCI IDs > > > - Added missing Exar XR17V25X PCI IDs > > > - Moved XR17V4358 and XR17V8358 PCI ID defines to pci_ids.h > > > > Did you read the top of the pci_ids.h file? Don't add new ids there > > unless it is going to be needed in multiple files please. > > > > thanks, > > > > greg k-h > No sorry I missed that... I was just trying to consolidate them all > in one place. > > Would it be better to move all the Connect Tech sub-IDs from > pci_ids.h into 8250_exar.c? Or should I just add the missing ones > to 8250_exar.c instead of pci_ids.h? Just add the missing ones if you don't want to touch the pci_ids.h file, that way it's a simpler change. thanks, greg k-h
