On Thu, 11 Apr 2024 17:55:54 +0200 Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > On Thu, Apr 11, 2024 at 11:29:27AM -0400, parker@xxxxxxxxx wrote: > > From: Parker Newman <pnewman@xxxxxxxxxxxxxxx> > > > > This patch adds support for most of Connect Tech's (CTI) PCI/PCIe > > serial cards to the 8250_exar driver. > > > > Major changes: > > - Added (optional) board_setup function called once during probe > > - Added exar_get_nr_ports function > > - Removed old Connect Tech setup functions > > - Added new UART family based CTI setup functions > > - Added PCI IDs entries for Exar XR17V25x and CTI FPGA based cards > > - Added MPIO functions for configuring/setting a single MPIO > > - Added support for reading from the Exar EEPROM > > When you need to list the different things you did in a single patch, > that's a huge hint it needs to be broken up into smaller, easier to > review, pieces. > > > > > Signed-off-by: Parker Newman <pnewman@xxxxxxxxxxxxxxx> > > --- > > drivers/tty/serial/8250/8250_exar.c | 1089 +++++++++++++++++++++++++-- > > 1 file changed, 1019 insertions(+), 70 deletions(-) > > Reviewing 1000 lines of changes at once that does different things, > isn't easy. Please break this up into smaller, > one-logical-step-at-a-time patches. > > thanks, > > greg k-h I will try to split it up better and submit a v2. Thank you, - Parker
