On 4/10/2024 5:46 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > > Add a PCI power control driver that's capable of correctly powering up > devices using the power sequencing subsystem. The first user of this > driver is the ath11k module on QCA6390. [...] > +config PCI_PWRCTL_PWRSEQ > + tristate "PCI Power Control driver using the Power Sequencing subsystem" > + select POWER_SEQUENCING > + select PCI_PWRCTL > + default m if (ATH11K_PCI && ARCH_QCOM) [...] > +static const struct of_device_id pci_pwrctl_pwrseq_of_match[] = { > + { > + /* ATH11K in QCA6390 package. */ > + .compatible = "pci17cb,1101", > + .data = "wlan", > + }, > + { > + /* ATH12K in WCN7850 package. */ > + .compatible = "pci17cb,1107", > + .data = "wlan", since you are adding both ath11k and ath12k packages, should you update the commit text and the config "default m if" condition to include ath12k? /jeff