Re: [PATCH V1] PCI: tegra194: Fix probe path for Endpoint mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 01/04/2024 16:01, Vidya Sagar wrote:
Tegra194 PCIe probe path is taking failure path in success case for
Endpoint mode. Return success from the switch case instead of going
into the failure path.

Signed-off-by: Vidya Sagar <vidyas@xxxxxxxxxx>

Fixes: c57247f940e8 ("PCI: tegra: Add support for PCIe endpoint mode in Tegra194")

---
  drivers/pci/controller/dwc/pcie-tegra194.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
index 4bba31502ce1..1a8178dc899a 100644
--- a/drivers/pci/controller/dwc/pcie-tegra194.c
+++ b/drivers/pci/controller/dwc/pcie-tegra194.c
@@ -2273,11 +2273,14 @@ static int tegra_pcie_dw_probe(struct platform_device *pdev)
  		ret = tegra_pcie_config_ep(pcie, pdev);
  		if (ret < 0)
  			goto fail;
+		else
+			return 0;
  		break;
default:
  		dev_err(dev, "Invalid PCIe device type %d\n",
  			pcie->of_data->mode);
+		ret = -EINVAL;
  	}
fail:


Otherwise ...

Reviewed-by: Jon Hunter <jonathanh@xxxxxxxxxx>

Jon

--
nvpublic




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux