Re: [PATCH 1/1] misc: pci_endpoint_test: Refactor dma_set_mask_and_coherent() logic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 28, 2024 at 12:06:32PM -0400, Frank Li wrote:
> dma_set_mask_and_coherent() will never return failure when mask >= 32bit.
> So needn't  fall back to set dma_set_mask_and_coherent(32).
> 
> Even if dma_set_mask_and_coherent(48) failure,
> dma_set_mask_and_coherent(32) will be failure according to the same reason.
> 
> The function dma_set_mask_and_coherent() defines the device DMA access
> address width. If it's capable of accessing 48 bits, it inherently supports
> 32-bit space as well.
> 
> Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> ---

Kishon,

do you remember why you set the DMA mask to 48-bits in the first place?
It seems a bit random.


Kind regards,
Niklas




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux