On Fri, Mar 29, 2024 at 06:09:32PM +0900, Damien Le Moal wrote:
> In pci_epf_test_unbind(), replace the call to cancel_delayed_work() to
> cancel the command handler delayed work with the synchronous version
> cancel_delayed_work_sync(). This ensure that the command handler is
> really stopped when proceeding with dma and bar cleanup.
How about simple said
"Replace cancel_delayed_work() with cancel_delayed_work_sync() in
pci_epf_test_unbind() to ensure that the command handler is really stopped
when proceeding with dma and bar cleanup."
>
> Signed-off-by: Damien Le Moal <dlemoal@xxxxxxxxxx>
Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
> ---
> drivers/pci/endpoint/functions/pci-epf-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
> index 0e285e539538..ab40c3182677 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-test.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-test.c
> @@ -709,7 +709,7 @@ static void pci_epf_test_unbind(struct pci_epf *epf)
> struct pci_epf_bar *epf_bar;
> int bar;
>
> - cancel_delayed_work(&epf_test->cmd_handler);
> + cancel_delayed_work_sync(&epf_test->cmd_handler);
> pci_epf_test_clean_dma_chan(epf_test);
> for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) {
> epf_bar = &epf->bar[bar];
> --
> 2.44.0
>
