On Tue, Mar 26, 2024 at 08:52:36PM +0900, Damien Le Moal wrote: > On 3/26/24 19:19, kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git enumeration > > head: 8694697a54096ae97eb38bf4144f2d96c64c68f2 > > commit: 8694697a54096ae97eb38bf4144f2d96c64c68f2 [28/28] PCI: Remove PCI_IRQ_LEGACY > > config: i386-buildonly-randconfig-001-20240326 (https://download.01.org/0day-ci/archive/20240326/202403261840.1RP419n5-lkp@xxxxxxxxx/config) > > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240326/202403261840.1RP419n5-lkp@xxxxxxxxx/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202403261840.1RP419n5-lkp@xxxxxxxxx/ > > > > All errors (new ones prefixed by >>): > > > > drivers/mfd/intel-lpss-pci.c: In function 'intel_lpss_pci_probe': > >>> drivers/mfd/intel-lpss-pci.c:57:49: error: 'PCI_IRQ_LEGACY' undeclared (first use in this function); did you mean 'NR_IRQS_LEGACY'? > > 57 | ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_LEGACY); > > | ^~~~~~~~~~~~~~ > > | NR_IRQS_LEGACY > > drivers/mfd/intel-lpss-pci.c:57:49: note: each undeclared identifier is reported only once for each function it appears in > > Bjorn, > > Not sure what is going on here. I did an allyesconfig build on x86_64 and did > not see such issue. Did the build bot missed some patches ? > > And the above also reminds me that we could change NR_IRQS_LEGACY to > NR_IRQS_INTX too. Sorry, this is my fault because I dropped the intel-lpss-pci.c patch because I was thinking Andy's patch would make it obsolete [1]. And it *does*, but we don't know the ordering of when his patch and this series will be merged into -next or upstream, so ... Anyway, I blew it, and I restore the intel-lpss-pci.c patch in the series, and we'll just have a trivial merge conflict to resolve until they're both upstream. Sorry for all the confusion. Bjorn [1] https://lore.kernel.org/r/20240325210444.GA1449676@bhelgaas
