Re: [PATCH v3 2/3] Remove conditional branch that is not suitable for cxl1.1 devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Kobayashi,Daisuke wrote:
> This patch removes conditional branching that does not comply with the specifications.
> 
> In the existing code, there is a conditional branch that compares "chbs->length" 
> with "CXL_RCRB_SIZE". However, according to the specifications, "chbs->length" 
> indicates the length of the CHBS structure in the cedt, not the size of the 
> configuration space. Therefore, since this condition does not comply with
> the specifications(cxl3.0 specification 9.17.1), remove it.

No, in Table 9-21 in CXL 3.1:

Base: If CXL Version = 0000 0000h, this represents the base address of
the RCH Downstream Port RCRB

Length: If CXL Version = 0000 0000h, this field must be set to 8 KB
(2000h)

The size of the CHBS structure is always much less than 8KB.




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux