On Tue, May 1, 2012 at 6:37 PM, Hao, Xudong <xudong.hao@xxxxxxxxx> wrote: >> -----Original Message----- >> From: Bjorn Helgaas [mailto:bhelgaas@xxxxxxxxxx] >> Sent: Saturday, April 28, 2012 1:42 AM >> To: Hao, Xudong >> Cc: linux-pci@xxxxxxxxxxxxxxx; Don Dutile; Matthew Wilcox; Zhang, Xiantao >> Subject: Re: [PATCH v6] Quirk for IVB graphics FLR errata >> >> On Fri, Apr 27, 2012 at 01:26:18AM +0000, Hao, Xudong wrote: >> > Maybe something configuration wrong on my mail client, I attach the patch >> as an attachment, can you open it in your side? >> >> Yes, I could open the attachment. But it makes it easier for everybody to >> read & review your patches if you can figure out how to post patches >> directly in the message rather than as an attachment. >> > > Sure, I'm trying configure my email, make it better to work. > >> Here's an updated version of your patch. I changed the following: >> >> - Wrapped changelog text so it fits nicely for "git log". >> - Added #define for 0xd0100 offset (please supply a more useful name). >> - Used pci_iomap() and ioread32()/iowrite32(). >> - Used msleep() rather than spinning (Matthew suggested this earlier, >> but you apparently missed it). Note that I went back to your >> original "do {} while ()" structure to make sure we read PCH_PP_STATUS >> at least once. >> - Added message if reset times out. >> >> This is still x86-specific code that clutters all other architectures. We >> might fix this someday by adding a DECLARE_PCI_FIXUP_RESET(), so the IVB >> code could live in arch/x86, and the linker could still collect all the >> device-specific reset methods. But I haven't done that yet. >> >> Please test and comment on this (and supply a name for 0xd0100): >> > > We can named 0xd0100 "NSDE_PWR_STATE" instead of "XXXX" in code. > > Testing done, patch works. > > I do not send patch again, can you replace XXXX to NSDE_PWR_STATE and apply this patch? Fixed up and applied to my "next" branch, thanks. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
