Re: [PATCH] PCI: brcmstb: fix broken brcm_pcie_mdio_write() polling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 02.03.24 um 10:45 schrieb Stefan Wahren:
Hi,

Am 17.02.24 um 18:27 schrieb Florian Fainelli:


On 2/17/2024 5:37 AM, Stefan Wahren wrote:
From: Jonathan Bell <jonathan@xxxxxxxxxxxxxxx>

MDIO_WR_DONE() tests bit 31, which is always 0 (==done) as
readw_poll_timeout_atomic does a 16-bit read. Replace with the readl
variant.

Fixes: ca5dcc76314d ("PCI: brcmstb: Replace status loops with
read_poll_timeout_atomic()")
Signed-off-by: Jonathan Bell <jonathan@xxxxxxxxxxxxxxx>
Signed-off-by: Stefan Wahren <wahrenst@xxxxxxx>

Excellent catch! Not sure what the real world impact was.

Acked-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
is there anything what prevents this patch from being applied?
ping





[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux