[PATCH 2/2] Add better warnings about invalid VPD data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Some Mellanox Connect-X 3 cards have firmware bugs which return
unfinished VPD data. This change helps to diagnose such issues
with clear warning messages.
---
 drivers/pci/vpd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/vpd.c b/drivers/pci/vpd.c
index daaa208c9d9c..fc38a611dd3e 100644
--- a/drivers/pci/vpd.c
+++ b/drivers/pci/vpd.c
@@ -87,10 +87,11 @@ static size_t pci_vpd_size(struct pci_dev *dev)
                                return off;
                }
        }
+       pci_warn(dev, "missing VPD_STIN_END at offset %zu\n", off + 1);
        return PCI_VPD_SZ_INVALID;
 
 error:
-       pci_info(dev, "invalid VPD tag %#04x (size %zu) at offset
%zu%s\n",
+       pci_warn(dev, "invalid VPD tag %#04x (size %zu) at offset
%zu%s\n",
                 header[0], size, off, off == 0 ?
                 "; assume missing optional EEPROM" : "");
        return PCI_VPD_SZ_INVALID;
-- 
2.39.2






[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux