On Sat, Apr 28, 2012 at 1:26 PM, Matthew Wilcox <matthew@xxxxxx> wrote: > On Wed, Apr 25, 2012 at 05:36:32PM -0600, Bjorn Helgaas wrote: >> @@ -2161,6 +2161,9 @@ bytes respectively. Such letter suffixes can also be entirely omitted. >> on: Turn realloc on >> realloc same as realloc=on >> noari do not use PCIe ARI. >> + pcie_scan_all Scan all possible PCIE devices. Otherwise we >> + only look for one device below a PCIE downstream >> + port. > > We should probably s/device/slot/ throughout. I've recently become > aware of a hype-rvisor that doesn't include PCI device number remapping, > so if you assign, say, function 03.6 to a guest, the PCI scanning code > doesn't find it. "Device" has a clear meaning in the context of PCIe addressing, i.e., bus/device/function numbers. But the spec uses "slot" to refer to a physical place where an add-in card can be inserted and things related to that place, e.g., power, hot-plug buttons, latches, chassis labels, etc. So I don't understand what you're proposing here. I don't know what "scan all possible PCIe slots" would mean because I don't know what that change would look like in the code. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
