On Thu, Feb 29, 2024 at 01:56:23PM +0100, Niklas Cassel wrote: > Hello Mani, > > On Sat, Feb 24, 2024 at 12:24:16PM +0530, Manivannan Sadhasivam wrote: > > All of the APIs are missing the Kernel-doc comments. Hence, add them. > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > > --- > > drivers/pci/controller/dwc/pcie-designware-ep.c | 92 +++++++++++++++++++++++++ > > 1 file changed, 92 insertions(+) > > > > diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c > > index fed4c2936c78..cdcb33a279db 100644 > > --- a/drivers/pci/controller/dwc/pcie-designware-ep.c > > +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c > > (snip) > > > @@ -556,6 +606,12 @@ int dw_pcie_ep_raise_msix_irq(struct dw_pcie_ep *ep, u8 func_no, > > return 0; > > } > > > > +/** > > + * dw_pcie_ep_cleanup - Cleanup DWC EP resources > > + * @ep: DWC EP device > > + * > > + * Cleans up the DWC EP specific resources like eDMA etc... > > I think that you should mention that this is only for glue drivers that > use PERST# handling, so that other glue drivers do no start using it :) > You are right. Will add the wording. - Mani -- மணிவண்ணன் சதாசிவம்
