Re: [PATCH v3 1/2] ACPI: use %pe for better readability of errors while printing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 16, 2024 at 6:54 AM Onkarnath <onkarnath.1@xxxxxxxxxxx> wrote:
>
> >On Tue, Feb 13, 2024 at 9:20 AM Onkarnarth <onkarnath.1@xxxxxxxxxxx> wrote:
> >>
> >> From: Onkarnath <onkarnath.1@xxxxxxxxxxx>
> >>
> >> As %pe is already introduced, it's better to use it in place of (%ld) for
> >> printing errors in logs. It would enhance readability of logs.
> >>
> >> Signed-off-by: Maninder Singh <maninder1.s@xxxxxxxxxxx>
> >
> >What exactly is the role of this S-o-b?  Has the person helped you to
> >develop the patch or something else?
> >
>
> Yes It was meant for Co-developed tag, Because We are working collectively for making errors more readable for our product kernel.(5.4)
> And some part of this patch was made by him.
>
> Then we checked that it is also suggested by open source to have %pe for printing errors:
> https://lore.kernel.org/all/92972476-0b1f-4d0a-9951-af3fc8bc6e65@suswa.mountain/
>
> So I prepared same changes for open source kernel, and because of smaller patch I kept it as normal signed-off tag only.
> If it is needed I can resend with Co-developed tag.

No need, I can add it for you.  Thanks for the explanation!





[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux