Re: [PATCH v2 1/2] ACPI: use %pe for better readability of errors while printing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 12, 2024 at 03:54:03PM +0530, Onkarnarth wrote:
> From: Onkarnath <onkarnath.1@xxxxxxxxxxx>
> 
> As %pe is already introduced, it's better to use it in place of (%ld) for
> printing errors in logs. It would enhance readability of logs.
> 
> Signed-off-by: Maninder Singh <maninder1.s@xxxxxxxxxxx>
> Signed-off-by: Onkarnath <onkarnath.1@xxxxxxxxxxx>
> Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@xxxxxxxxxxxxxxx>
> Reviewed-by: Bjorn Helgaas <helgaas@xxxxxxxxxx>

This tag is wrong.  I provided some feedback, but that's not the same
as providing a "Reviewed-by" tag.  "Reviewed-by" has a very specific
meaning and the reviewer must provide it explicitly; details here:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v6.7#n544

Bjorn




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux