Re: [PATCH] PCI: Add vf reset notification for pf

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 04.02.24 um 07:12 schrieb Emily Deng:
When a vf has been reset, the pf wants to get notification to remove the vf
out of schedule.

Solution:
Add the callback function in pci_driver sriov_vf_reset_notification. When
vf reset happens, then call this callback function.

Well that doesn't make much sense. As other already noted as well a VF should be an encapsulated representation of a physical devices functionality.

AMD implemented that a bit different with a hypervisor to control which PF functionality a VF exposes, but that doesn't mean that we can leak this AMD specific handling into the common Linux PCI subsystem.

Additional to that a technical blocker is that when a VF is passed into a VM you don't have access to the PF any more to make this reset notification.

Regards,
Christian.


Signed-off-by: Emily Deng <Emily.Deng@xxxxxxx>
---
  drivers/pci/pci.c   | 8 ++++++++
  include/linux/pci.h | 1 +
  2 files changed, 9 insertions(+)

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 60230da957e0..aca937b05531 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -4780,6 +4780,14 @@ EXPORT_SYMBOL_GPL(pcie_flr);
   */
  int pcie_reset_flr(struct pci_dev *dev, bool probe)
  {
+	struct pci_dev *pf_dev;
+
+	if (dev->is_virtfn) {
+		pf_dev = dev->physfn;
+		if (pf_dev->driver->sriov_vf_reset_notification)
+			pf_dev->driver->sriov_vf_reset_notification(pf_dev, dev);
+	}
+
  	if (dev->dev_flags & PCI_DEV_FLAGS_NO_FLR_RESET)
  		return -ENOTTY;
diff --git a/include/linux/pci.h b/include/linux/pci.h
index c69a2cc1f412..4fa31d9b0aa7 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -926,6 +926,7 @@ struct pci_driver {
  	int  (*sriov_configure)(struct pci_dev *dev, int num_vfs); /* On PF */
  	int  (*sriov_set_msix_vec_count)(struct pci_dev *vf, int msix_vec_count); /* On PF */
  	u32  (*sriov_get_vf_total_msix)(struct pci_dev *pf);
+	void  (*sriov_vf_reset_notification)(struct pci_dev *pf, struct pci_dev *vf);
  	const struct pci_error_handlers *err_handler;
  	const struct attribute_group **groups;
  	const struct attribute_group **dev_groups;





[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux