On Tue, Jan 30, 2024 at 08:32:09PM +0100, Niklas Cassel wrote: > Refactor pci_epf_alloc_space() to take epc_features as a parameter. > This is a preparation patch needed for further cleanups. > > Signed-off-by: Niklas Cassel <cassel@xxxxxxxxxx> One comment below. With that addressed, Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > --- > drivers/pci/endpoint/functions/pci-epf-ntb.c | 2 +- > drivers/pci/endpoint/functions/pci-epf-test.c | 5 ++--- > drivers/pci/endpoint/functions/pci-epf-vntb.c | 4 ++-- > drivers/pci/endpoint/pci-epf-core.c | 6 ++++-- > include/linux/pci-epf.h | 4 +++- > 5 files changed, 12 insertions(+), 9 deletions(-) > [...] > diff --git a/drivers/pci/endpoint/pci-epf-core.c b/drivers/pci/endpoint/pci-epf-core.c > index 2c32de667937..e44f4078fe8b 100644 > --- a/drivers/pci/endpoint/pci-epf-core.c > +++ b/drivers/pci/endpoint/pci-epf-core.c > @@ -251,14 +251,16 @@ EXPORT_SYMBOL_GPL(pci_epf_free_space); > * @epf: the EPF device to whom allocate the memory > * @size: the size of the memory that has to be allocated > * @bar: the BAR number corresponding to the allocated register space > - * @align: alignment size for the allocation region > + * @epc: the features provided by the EPC specific to this endpoint function > * @type: Identifies if the allocation is for primary EPC or secondary EPC > * > * Invoke to allocate memory for the PCI EPF register space. > */ > void *pci_epf_alloc_space(struct pci_epf *epf, size_t size, enum pci_barno bar, > - size_t align, enum pci_epc_interface_type type) > + const struct pci_epc_features *epc_features, s/epc/epc_features - Mani -- மணிவண்ணன் சதாசிவம்
