On Thu, Feb 01, 2024 at 05:02:25PM +1100, Alexey Kardashevskiy wrote: > Already public pci_doe() takes a protocol type argument. > PCIe 6.0 defines three, define them in a header for use with pci_doe(). [...] > --- a/include/linux/pci-doe.h > +++ b/include/linux/pci-doe.h > @@ -13,6 +13,10 @@ > #ifndef LINUX_PCI_DOE_H > #define LINUX_PCI_DOE_H > > +#define PCI_DOE_PROTOCOL_DISCOVERY 0 > +#define PCI_DOE_PROTOCOL_CMA_SPDM 1 > +#define PCI_DOE_PROTOCOL_SECURED_CMA_SPDM 2 These are deliberately defined in the .c files which actually need them, i.e. DISCOVERY is defined in drivers/pci/doe.c and CMA_SPDM is defined in drivers/pci/cma.c: https://lore.kernel.org/all/7721bfa3b4f8a99a111f7808ad8890c3c13df56d.1695921657.git.lukas@xxxxxxxxx/ I don't see why they would have to be public if they're each only needed in a single .c file. Thanks, Lukas
