> > On Mon, Jan 29, 2024 at 04:21:12PM -0600, Rob Herring wrote: > > > > On Mon, 29 Jan 2024 09:01:39 +0800, Minda Chen wrote: > > > Add StarFive JH7110 SoC PCIe controller dt-bindings. JH7110 using > > > PLDA XpressRICH PCIe host controller IP. > > > > > > Signed-off-by: Minda Chen <minda.chen@xxxxxxxxxxxxxxxx> > > > Reviewed-by: Hal Feng <hal.feng@xxxxxxxxxxxxxxxx> > > > Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > > --- > > > .../bindings/pci/starfive,jh7110-pcie.yaml | 120 ++++++++++++++++++ > > > 1 file changed, 120 insertions(+) > > > create mode 100644 > > > Documentation/devicetree/bindings/pci/starfive,jh7110-pcie.yaml > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m > dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/s > tarfive,jh7110-pcie.yaml: > > Error in referenced schema matching $id: > > http://devicetree.org/schemas/pci/plda,xpressrich3-axi-common.yaml > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/s > tarfive,jh7110-pcie.example.dtb: pcie@940000000: False schema does not > allow {'compatible': ['starfive,jh7110-pcie'], 'reg': [[9, 1073741824, 0, > 268435456], [0, 721420288, 0, 16777216]], 'reg-names': ['cfg', 'apb'], > '#address-cells': [[3]], '#size-cells': [[2]], '#interrupt-cells': [[1]], 'device_type': > ['pci'], 'ranges': [[2181038080, 0, 805306368, 0, 805306368, 0, 134217728], > [3271557120, 9, 0, 9, 0, 0, 1073741824]], 'starfive,stg-syscon': [[4294967295]], > 'bus-range': [[0, 255]], 'interrupts': [[56]], 'interrupt-map-mask': [[0, 0, 0, 7]], > 'interrupt-map': [[0, 0, 0, 1, 2, 1], [0, 0, 0, 2, 2, 2], [0, 0, 0, 3, 2, 3], [0, 0, 0, 4, 2, 4]], > 'msi-controller': True, 'clocks': [[4294967295, 86], [4294967295, 10], > [4294967295, 8], [4294967295, 9]], 'clock-names': ['noc', 'tl', 'axi_mst0', 'apb'], > 'resets': [[4294967295, 11], [4294967295, 12], [4294967295, 13], [4294967295, > 14], [4294967295, 15], [4294967295, 16]], 'perst-gpios': [[4294967295, 26, 1]], > 'phys': [[4294967295]], 'interrupt-controller': {'#address-cells': [[0]], > '#interrupt-cells': [[1]], 'interrupt-controller': True, 'phandle': [[2]]}, '$nodename': > ['pcie@940000000']} > > from schema $id: > > http://devicetree.org/schemas/pci/starfive,jh7110-pcie.yaml# > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/s > tarfive,jh7110-pcie.example.dtb: pcie@940000000: Unevaluated properties are > not allowed ('#address-cells', '#interrupt-cells', '#size-cells', 'bus-range', > 'device_type', 'interrupt-controller', 'interrupt-map', 'interrupt-map-mask', > 'interrupts', 'msi-controller', 'ranges', 'reg', 'reg-names' were unexpected) > > from schema $id: > > http://devicetree.org/schemas/pci/starfive,jh7110-pcie.yaml# > > These are probably due to only patches 16-22 showing up in lore. > > Rob Yes. The plda,xpressrich3-axi-common.yaml file is not added to kernel. Error in referenced schema matching $id: > > http://devicetree.org/schemas/pci/plda,xpressrich3-axi-common.yaml
